<html>
<head><meta charset="utf-8"><title>rustc-guides-stages · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html">rustc-guides-stages</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="163566261"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566261" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566261">(Apr 17 2019 at 14:35)</a>:</h4>
<p><span class="user-mention" data-user-id="209053">@Iñaki Garay</span> let's talk here</p>



<a name="163566319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566319">(Apr 17 2019 at 14:36)</a>:</h4>
<p>so, I was saying</p>



<a name="163566320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566320">(Apr 17 2019 at 14:36)</a>:</h4>
<p>about <a href="https://github.com/rust-lang/rustc-guide/pull/301" target="_blank" title="https://github.com/rust-lang/rustc-guide/pull/301">https://github.com/rust-lang/rustc-guide/pull/301</a></p>



<a name="163566346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566346">(Apr 17 2019 at 14:36)</a>:</h4>
<p>please, squash commits and make separate PRs for the stages docs and for the broken links</p>



<a name="163566379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566379">(Apr 17 2019 at 14:37)</a>:</h4>
<p>leave <a href="https://github.com/rust-lang/rustc-guide/pull/301" target="_blank" title="https://github.com/rust-lang/rustc-guide/pull/301">https://github.com/rust-lang/rustc-guide/pull/301</a> for the stages documentation</p>



<a name="163566520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163566520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163566520">(Apr 17 2019 at 14:38)</a>:</h4>
<p>roger!</p>



<a name="163612462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163612462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163612462">(Apr 18 2019 at 00:15)</a>:</h4>
<p>Is the travis build failing expected? Looking at the build output from <a href="https://travis-ci.com/rust-lang/rustc-guide/builds/108764339" target="_blank" title="https://travis-ci.com/rust-lang/rustc-guide/builds/108764339">https://travis-ci.com/rust-lang/rustc-guide/builds/108764339</a> it looks like it's trying to compile the sample output text enclosed in triple backticks. I'll add a bash qualifier to the section while I add the additional discussion in <a href="https://github.com/rust-lang/rust/issues/57963#issuecomment-458429280" target="_blank" title="https://github.com/rust-lang/rust/issues/57963#issuecomment-458429280">https://github.com/rust-lang/rust/issues/57963#issuecomment-458429280</a> but correct me preemptively if I'm wrong.</p>



<a name="163752352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/163752352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#163752352">(Apr 19 2019 at 18:03)</a>:</h4>
<p>Just an update. Addressed PR comments but still rewording the discussion on issue 57963.</p>



<a name="164215594"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215594" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215594">(Apr 25 2019 at 22:26)</a>:</h4>
<p>This <a href="https://github.com/rust-lang/rustc-guide/pull/307" target="_blank" title="https://github.com/rust-lang/rustc-guide/pull/307">https://github.com/rust-lang/rustc-guide/pull/307</a> has to be merged before I can rebase and send the newest additions.</p>



<a name="164215654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215654">(Apr 25 2019 at 22:27)</a>:</h4>
<p><span class="user-mention" data-user-id="209053">@Iñaki Garay</span> something is wrong in the PR, the title is about broken links but there is a commit about the stages</p>



<a name="164215661"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215661" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215661">(Apr 25 2019 at 22:27)</a>:</h4>
<p>I guess I'd split those and just provide the links commits in that PR</p>



<a name="164215664"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215664" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215664">(Apr 25 2019 at 22:27)</a>:</h4>
<p>or what was your idea?</p>



<a name="164215728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215728">(Apr 25 2019 at 22:28)</a>:</h4>
<p>hmmm you're right</p>



<a name="164215741"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215741" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215741">(Apr 25 2019 at 22:28)</a>:</h4>
<p>how did that get in there?</p>



<a name="164215970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164215970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164215970">(Apr 25 2019 at 22:32)</a>:</h4>
<p>ah, my GH master has bad commits in it, fixing</p>



<a name="164216081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164216081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164216081">(Apr 25 2019 at 22:34)</a>:</h4>
<p>that's more like it, fixed <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span></p>



<a name="164216339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164216339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164216339">(Apr 25 2019 at 22:39)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="164216374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164216374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164216374">(Apr 25 2019 at 22:39)</a>:</h4>
<p>I don’t have commit access so can’t merge it</p>



<a name="164216484"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164216484" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164216484">(Apr 25 2019 at 22:41)</a>:</h4>
<p>Travis is still failing because of another unrelated error. <code>mdbook test</code> is failing because of the two phase borrow changes.</p>



<a name="164216608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164216608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164216608">(Apr 25 2019 at 22:43)</a>:</h4>
<p>This is the code snippet <a href="https://github.com/rust-lang/rustc-guide/pull/305/files#diff-5311fe548c2eb1bbb4b4ab3ca2151676R18" target="_blank" title="https://github.com/rust-lang/rustc-guide/pull/305/files#diff-5311fe548c2eb1bbb4b4ab3ca2151676R18">https://github.com/rust-lang/rustc-guide/pull/305/files#diff-5311fe548c2eb1bbb4b4ab3ca2151676R18</a> </p>
<p>I'm not sure whether the example code needs to be fixed or simply marked as <code>ignore</code></p>



<a name="164217229"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164217229" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164217229">(Apr 25 2019 at 22:53)</a>:</h4>
<p>I see, the example code didn't compile with my outdated (rustc 1.36.0-nightly (33fe1131c 2019-04-20)) nightly compiler but it did after I ran <code>rustup update</code> (with rustc 1.36.0-nightly (e305df184 2019-04-24)) </p>
<p>So I guess it's just a matter of waiting for the CI toolchain to be updated (how does that happen? manooallee? automagically?) and not <code>ignore</code>ing the snippet</p>



<a name="164499071"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164499071" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Iñaki Garay <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164499071">(Apr 29 2019 at 23:59)</a>:</h4>
<p>PR finally updated. I swear the wait between submission and review feels like waiting for college grades all over again xD</p>



<a name="164537998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164537998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164537998">(Apr 30 2019 at 13:21)</a>:</h4>
<p><span class="user-mention" data-user-id="209053">@Iñaki Garay</span> I don't know if people care that much, but I'd split in 2 commits, one the markdown/style fixes and another one with the real content</p>



<a name="164538016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164538016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164538016">(Apr 30 2019 at 13:21)</a>:</h4>
<p>makes things cleaner and easier to review in general</p>



<a name="164541873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/rustc-guides-stages/near/164541873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/rustc-guides-stages.html#164541873">(Apr 30 2019 at 14:10)</a>:</h4>
<p>left some comments</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>